Skip to content

Fix processing of TypeSpec #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix processing of TypeSpec #160

merged 1 commit into from
Jun 2, 2023

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 2, 2023

Description

  • Method was missing the code to create an entry in the table in case it was missing.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Method was missing the code to create an entry in the table in case it was missing.
@nfbot nfbot added the Type: bug Something isn't working label Jun 2, 2023
@josesimoes josesimoes merged commit c1fd20d into nanoframework:main Jun 2, 2023
@josesimoes josesimoes deleted the fix-1164 branch June 2, 2023 12:17
josesimoes added a commit that referenced this pull request Jun 2, 2023
- Replicates #160 with the current approach.
- Addresses nanoframework/Home#1164.
josesimoes added a commit that referenced this pull request Jun 2, 2023
- Replicates #160 with the current approach.
- Addresses nanoframework/Home#1164.
- Add test code to TestApp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Update Dependents Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeof for array types returns invalid data
2 participants