-
-
Notifications
You must be signed in to change notification settings - Fork 31
Fix Guid.TryParseGuidWithDashes()
and Guid
constructor with string parameter
#240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Rework implementation to deal with recent changes in backing fields. - Rename parameters to match TryParse. - Update Intellisense comments to match TryParse. - Update Intellisense comments of constructor from string to include only the accepted formats. - Minor code change in the string constructor so it doesn't pass the Guid class as parameter to TryParseGuidWithDashes. - Add Obsolete attribute with note that the method will be renamed to TryParse in a future version. - Add unit tests to cover this method. - Add more unit tests for constructors and interaction with Empty property.
Guid.TryParseGuidWithDashes
and Guid
constructor with string parameter
Guid.TryParseGuidWithDashes
and Guid
constructor with string parameterGuid.TryParseGuidWithDashes()
and Guid
constructor with string parameter
|
Description
TryParse
.TryParse
.Guid
class as parameter toTryParseGuidWithDashes
.TryParse
in a future version.Empty
property.Motivation and Context
TryParseGuidWithDashes
toTryParse
as there is no good reason to deviate from the full .NET API.How Has This Been Tested?
Screenshots
Types of changes
Checklist:
cc @sky9mike