Added pool.end()

[dbernar1]

As brought up in #911

Please let me know if you would like me to adjust...

[dougwilson]

Thank you so much!

[dbernar1]

You're welcome, Doug.

[tellnes]

This link is damned to go wrong fast when thing changes. It probably is already.

[dbernar1]

Thank you. Do you have a proposed / usual way of dealing with this?

Dan Bernardic
My contact information is at http://gravatar.com/dbernar1

On Sep 29, 2014, at 5:43 AM, Christian Tellnes notifications@github.com wrote:

In Readme.md:

@@ -320,6 +320,22 @@ being taken from the top of the pool and returning to the bottom.
When a previous connection is retrieved from the pool, a ping packet is sent
to the server to check if the connection is still good.

+## Terminating all the connections in a pool
+
+When you are done using the pool, you have to end all the connections or your
+script will hang until the db server closes them. To end all the connections
+in the pool, use
+pool.end()
This link is damned to go wrong fast when thing changes. It probably is already.

—
Reply to this email directly or view it on GitHub.

[tellnes]

Link to a specific version of the code instead of a branch. Eg. a commit or a tag. (just change master in the url to something else)

But do we really need to link to the implementation here?

[dbernar1]

Thanks very much for the tip. I was just looking at adjusting it, and it looks like Doug edited the commit before merging it. He seems to have removed the link and adjusted the wording somewhat.

See dc0d600

[tellnes]

Sorry, my bad. I should have checked the merged commit before commenting.

[dbernar1]

Not at all. Thanks for checking and the tip.

Believe it or not, I had wondered about a solution to going out of date, in context of the WordPress codex, so I am glad you told me.

Dan Bernardic
My contact information is at http://gravatar.com/dbernar1

On Sep 29, 2014, at 6:37 AM, Christian Tellnes notifications@github.com wrote:

In Readme.md:

@@ -320,6 +320,22 @@ being taken from the top of the pool and returning to the bottom.
When a previous connection is retrieved from the pool, a ping packet is sent
to the server to check if the connection is still good.

+## Terminating all the connections in a pool
+
+When you are done using the pool, you have to end all the connections or your
+script will hang until the db server closes them. To end all the connections
+in the pool, use
+pool.end()
Sorry, my bad. I should have checked the merged commit before commenting.

—
Reply to this email directly or view it on GitHub.

[dougwilson]

Yea, I removed the link because, really, it's not that useful to link into the source anyway :)