Add Pool option queueLimit #475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion if the queue of pending connection requests gets larger than the queueLimit. This is a safeguard to detect code which leaks connections sooner rather than later. The new functionality covered in test/integration/pool/test-queue-limit.js
|
@marcuswestin thx - LGTM. Added you as a collaborator on Github, feel free to merge this. Would be nice to have this added to the docs as well. |
marcuswestin
added a commit
that referenced
this pull request
May 14, 2013
…queued connection requests. Fixes issue #475.
|
Fixed in 621fc0d (together with documentation in Readme.md) |
|
@marcuswestin 💖 thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pool option queueLimit, which returns an error to Pool#getConnection if the queue of pending connection requests gets larger than the queueLimit. This is a safeguard to detect code which leaks connections sooner rather than later. The new functionality covered in test/integration/pool/test-queue-limit.js