Skip to content

Copy properties from sql object explicitly #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

blakeembrey
Copy link
Contributor

Closes #2253.

@dougwilson
Copy link
Member

Do you think using Object.create would be sufficient but still keep from maintaining a list at that location? Adding a test that represents the issue would enable me to answer my own question vs defer to you, ps :)

@blakeembrey
Copy link
Contributor Author

@dougwilson Yes, pretty sure, assuming no one is iterating over the Object.keys elsewhere within the project. Where should I add a test case? I kind of hoped the existing tests of cover this, since I'm not changing functionality.

@dougwilson
Copy link
Member

Where should I add a test case?

So the test files are in the test/ directory. You'll probably wanted to add them under unit since these are likely unit tests.

I kind of hoped the existing tests of cover this, since I'm not changing functionality.

Well, if there was an existing test, then I guess this PR is unneeded? Not sure why the test suite would be passing without your change here if there is already a test in this module's suite?

@blakeembrey
Copy link
Contributor Author

Well, if there was an existing test, then I guess this PR is unneeded? Not sure why the test suite would be passing without your change here if there is already a test in this module's suite?

Derp, right - let me add this.

@blakeembrey
Copy link
Contributor Author

Added a test that I believe should work given node 0.6's feature set.

@blakeembrey
Copy link
Contributor Author

@dougwilson Bump.

@dougwilson
Copy link
Member

I plan to have a new minor out next week and will get this in there.

Copy link
Member

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My humblest apologies on the delay...

@dougwilson dougwilson merged commit dbb07ed into mysqljs:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Support non-enumerable sql and values in query object
2 participants