Clear instructions for how to run unit tests

[marcuswestin]

It was not clear to me how to get the unit tests running. I added instructions to Readme.md for how to setup mysql and run the unit tests in e8ad4af, but some of the tests still fail due to incorrect user privilege setup.

It would be great if someone who knows the expected setup could flesh out and/or correct the instructions at https://github.com/felixge/node-mysql#running-unit-tests.

Thanks!

[felixge]

LGTM, but it renders bad: https://github.com/felixge/node-mysql#running-unit-tests

Could you add a fenced code block around the commands (tripple ticks)? This will make it render nicely.

[felixge]

Also: You may want to suggest people to create a config.sh file to store their settings in which they can source on demand.

[kai-koch]

While we are on the topic of testing:
I tried to run the tests on windows in a dos-shell, but it failed. :-)

Is there a way to run tests on windows without using some kind of linux-VM?

[marcuswestin]

@kai-koch Sorry, I don't know about running the tests of windows.

A few of the tests still fail for me as well.

Actually, I'll reopen this issue as it has not actually been fixed (some tests still fail using the given instructions.)

[felixge]

@kai-koch what did you try? What output did you get? I think you should be able to run the tests on windows, but I haven't tried myself before.

[kai-koch]

@felixge

 C:\node\untest\public_html\node_modules\mysql>npm test

> mysql@2.0.0-alpha8 test C:\node\untest\public_html\node_modules\mysql
> make test

Der Befehl "make" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

After shuffeling through google and stackoverflow and finding nothing useful than to install additional stuff to my system, I came to up with my own solution now. npm test runs fine with that.

I don't know what the *nix 'make' does exactly, but for testing purposes in node-mysql a simple 'make.bat' with setting the MYSQL_ enviroment variables and adapting the \test\integration\connection\test-unix-domain-socket.js will do. I try to issue a proper pull request, or post it here, if I fail at that pull-request.

[marcuswestin]

@kai-koch could you please publish your environment variables here? Would be nice to have them easily available for people to run a fully passing test suite with minimum effort.
-- while mobile

On Wed, May 15, 2013 at 3:44 PM, Kai Koch notifications@github.com
wrote:

@felixge

 C:\node\untest\public_html\node_modules\mysql>npm test
> mysql@2.0.0-alpha8 test C:\node\untest\public_html\node_modules\mysql
> make test
Der Befehl "make" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

After shuffeling through google and stackoverflow and finding nothing useful than to install additional stuff to my system, I came to up with my own solution now. npm test runs fine with that.

I don't know what the *nix 'make' does exactly, but for testing purposes in node-mysql a simple 'make.bat' with setting the MYSQL_ enviroment variables and adapting the \test\integration\connection\test-unix-domain-socket.js will do. I try to issue a proper pull request, or post it here, if I fail at that pull-request.

Reply to this email directly or view it on GitHub:
#487 (comment)

[kai-koch]

@marcuswestin
I have issued a pull request, which adds 'make' support for windows with out any additional installation and instructions in the readme.md .

#496

The pull request assumes, that the file 'make.bat' is not executed on unix. 'make.bat' contains the environment variables queried in common.js

The modified file 'test-unix-domain-socket.js' assumes, that the environment variable windir is not set on unix systems and skips the tests and inverts the assertion, if windir is set.

[marcuswestin]

#496 looks great @kai-koch! I added one note on just skipping the unix domain socket test when on windows - does that sound right to you?

I cleaned up the instructions for running the tests on OS X/Unix in a1f3db0, which addresses this issue.