ECONNRESET: TCP KeepAlive issue

[bertho-zero]

I have an ECONNRESET problem every X minutes, by default node does not activate KeepAlive on the socket (https://nodejs.org/api/net.html#net_socket_setkeepalive_enable_initialdelay)

It is possible to pass an optional socket but a solution as proposed in #2110 seems more suitable.

I saw #566, #878 and #1939

What do you think is the approach to take?

[bertho-zero]

It seems that we can pass a socket option:

mysql/lib/Connection.js

Line 18 in dbb07ed

this._socket = options.socket;

But this one is replaced during the connect:

mysql/lib/Connection.js

Lines 74 to 76 in dbb07ed

	this._socket = (this.config.socketPath)
	? Net.createConnection(this.config.socketPath)
	: Net.createConnection(this.config.port, this.config.host);

[dougwilson]

Yea, providing a socket option does nothing and it's really desired at this time with how the module works. Instead a config option will be added to enable / control the TCP keep alive on the socket that is created, similar to the referenced PR.