Improve binary value handling in queries (Python 3) #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write raw binary values to e.g. a
BINARY
orBLOB
column, one has to currently e.g. produce a hexadecimal representation to make sure MySQL always (and not just when the binary data is e.g. ASCII) interprets the input correctly:With the proposed change (only applicable to Python 3):
This is done by prepending the
_binary
prefix, see e.g. here and here.For Python 2,
bytearray
could be handled in a similar fashion but I wasn't sure how to best implement this in the C extension given it only deals withbytes
and notbytearray
currently, unlike the pure-Python version (where one could simply always prepend_binary
ifbuf
is bytearray (inconversion.py
).