Skip to content

Fix #272. Blob types should be accessible via byte[] #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

schveiguy
Copy link
Collaborator

This should fix the regression in #272

ping @SingingBush let me know if this is suitable for your project, or if we need more types to be included.

I haven't tested this yet, so will wait for CI to see if I made any mistakes!

@schveiguy schveiguy force-pushed the fix272 branch 2 times, most recently from b82a7a9 to 77a97c8 Compare February 5, 2023 19:36
@schveiguy
Copy link
Collaborator Author

ping again @SingingBush, any comments? If I don't hear from you for a few days, I'll just merge this and close the issue.

@SingingBush
Copy link

Sorry been hectic recently. I'll try it out tonight and get back to you

@SingingBush
Copy link

I've looked through the PR and it seems reasonable but I've not run locally. I noticed that there are now tests for byte[] and ubyte[] so that seems fine.

I was also trying to get it to work with std.datetime.systime.SysTime as an alternative to std.datetime.date.DateTime. SysTime includes timezone which makes it useful if using the timestamp type in MySQL.

According to MySQL docs:

MySQL converts TIMESTAMP values from the current time zone to UTC for storage, and back from UTC to the current time zone for retrieval. (This does not occur for other types such as DATETIME.) By default, the current time zone for each connection is the server's time.

So being able to retrieve columns as SysTime would be handy

@schveiguy
Copy link
Collaborator Author

SysTime includes timezone which makes it useful if using the timestamp type in MySQL.

If this is a new feature, and not an already-existing feature, can you open a new issue on it? I want to focus and making sure existing code doesn't break for this release. I agree, returning a SysTime might be useful. We do have a custom mysql Timestamp type, but I admit I never used it.

If it does work in 3.1.0, can you give me an example?

@schveiguy schveiguy merged commit fa4d3fb into mysql-d:master Feb 11, 2023
@schveiguy
Copy link
Collaborator Author

@SingingBush let me know if there are other problems that need addressing. Will push a new release.

@schveiguy schveiguy deleted the fix272 branch February 11, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants