Use utf8mb4 by default #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubo39
force-pushed
the
utf8mb4
branch
2 times, most recently
from
a7a65a3 to
81e5adc
Compare
|
This looks reasonable to me. I'll get back to this, and probably merge it. |
|
@kubo39 please rebase this as there's now a working CI process. It'd be good to see this get merged |
This commit changes default collation as "utf8mb4_generic_ci" which is available from MySQL 5.5.3.
schveiguy
requested changes
May 25, 2021
|
Also, unittests showing how this check works should be included. I know mysql-native has few true unittests, but this would also help show what this function is supposed to do. |
|
Ah, this looks much better! |
I think for this to be merged you may need to complete the review process to confirm the requested changes are complete. |
schveiguy
approved these changes
May 28, 2021
|
Reopened to trigger CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes default collation as "utf8mb4_generic_ci" which is
available from MySQL 5.5.3.