Skip to content

Serializable default #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2019
Merged

Serializable default #50

merged 5 commits into from
Apr 20, 2019

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Mar 28, 2017 •
edited
Loading

Test default serializable for check BC in future

@peter-gribanov peter-gribanov mentioned this pull request Mar 28, 2017
Closed
@peter279k
Copy link

It seems that the tests/EnumTest.php has conflict, it should be fixed.

peter279k
peter279k approved these changes Apr 19, 2019
View reviewed changes
Copy link

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

I suggest that it can squash all commits to one so that it can let the commits be clear on this PR.

@mnapoli
Copy link
Member

mnapoli commented Apr 20, 2019

Thank you!

@mnapoli mnapoli merged commit 6b7d5ee into myclabs:master Apr 20, 2019
@peter-gribanov peter-gribanov deleted the serializable-default branch April 22, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-gribanov @peter279k @mnapoli