Add caching to toArray method
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflection can be slow on occasions and this optimization should be beneficial if `toArray` is being called more than once per request.
|
Nice! But might as well cache the constants no? Something like: $classname = get_called_class();
if (! array_key_exists($calledClass, self::$constantsCache)) {
$reflectionClass = new \ReflectionClass($calledClass);
self::$constantsCache[$classname] = $reflection->getConstants();
}
return self::$constantsCache[$classname]; |
| * Store instantiated reflection objects in a static cache. | ||
| * @var array | ||
| */ | ||
| protected static $reflectionCache = array(); |
There was a problem hiding this comment.
I think it should be private, I see no use to making it accessible to subclasses
There was a problem hiding this comment.
Completely agree. Let me get this sorted.
- Cache constants rather than reflection objects - Make static cache private
|
Editing in github is no fun, but typo has gone and travis looks OK |
mnapoli
added a commit
that referenced
this pull request
Nov 11, 2013
Add caching to `toArray` method
|
Awesome, thanks for contributing. This has been released as 1.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflection can be slow on occasions and this optimization should be beneficial if
toArrayis being called more than once per request.