isValidKey using toArray() directly

[KKKas]

Now it doesn't need to use toArray()->array_keys->in_array, but just toArray() and isset[$key], which should be faster.

[mnapoli]

Hi, thanks this is a good change if it improves the performances.

However it fails on PHP 5.3 right now. Furthermore it uses isset() which will return false if an enum value is null (see this: http://3v4l.org/jPC6H). You should use array_key_exists() instead I think.

By the way it's too bad that the tests didn't pick that, maybe if you have time to add some tests you could test that:

class MyEnum extends Enum {
    const FOO = null;
}

$this->assertTrue(MyEnum::isValid(null));
new MyEnum(null); // should work

[mnapoli]

Wait I'm mixing things up… This is isValidKey() so it's impossible to define a constant name null :)

Fixing the PHP 5.3 error should be enough then ;)

[KKKas]

Hey,
Wow, I didn't know http://3v4l.org ;-) That's awesome tool. Thanks.

I think that now isValidKey() should be fine.

[mnapoli]

👍