Static method to get array of all enum instances

[chriseskow]

When using this library, I was slightly surprised to find that the toArray() method returns an associative array mapping the enum constant names to their underlying values, rather than to instances of the enum object wrapping the value. When adding additional behavior to the enum via instance methods, having the enum objects is often more useful than only the underlying constant values.

What do you think of adding a static method, e.g. getInstances(), returning an array mapping constant names to object instances?

[mnapoli]

Hi, this is indeed something I've never thought of, and never needed. But it makes sense, I can imagine plenty of scenarios where you would want to get the list of the actual enum instances…

I think if you make a PR I'd be +1 to merge it, if anybody else has a preference please voice it.

And yes, now I wish toArray() would return the instance list ;) But we have to keep BC. However we have keys(), and a few month ago someone suggested to rename toArray() to values(): we didn't because of BC issues, but we could name the new method values() it would make sense I think.

[chriseskow]

We could break BC and release it as 2.0... ;-)

[mnapoli]

No that's not the goal. As I said if the new method name is values() then there is no BC break.

[mnapoli]

I have tagged v1.4.0

[chriseskow]

Thanks!