-
-
Notifications
You must be signed in to change notification settings - Fork 464
Add functions to change sound effect parameters #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04c0c31
to
c9c3eab
Compare
5325fb5
to
9fc58a1
Compare
Looks good so far! Thank you so much for this PR. 🎉 |
@StrixG Do you want to work more on this PR? I think it looks good enough. |
Yes. I can't figure out how to make this work for the player voice. |
Do you think it is possible? I thought voice uses different library (not BASS) |
I believe voice is recorded via BASS and then encoded (for transmission) using Opus. |
No, we don't use BASS for recording. According to #895 we use |
There seems to be some issue with reverb, but I doubt it's from your side. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SoundEffectsTest.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested lightly and seems to be working fine 👍
Co-authored-by: Sarrum <thesarrum@gmail.com>
@StrixG All ready? Let's merge this, please create a new issue for the player voice part and create the Wiki pages. Thank you! Apologies for the long wait. |
This pull request adds functions to manipulate the parameters of sound effects. These functions doesn't work with the player voice at the moment.
Effect parameters
chorus
Chorus
http://www.un4seen.com/doc/#bass/BASS_DX8_CHORUS.html
compressor
Compressor
http://www.un4seen.com/doc/#bass/BASS_DX8_COMPRESSOR.html
distortion
Distortion
http://www.un4seen.com/doc/#bass/BASS_DX8_DISTORTION.html
echo
Echo
http://www.un4seen.com/doc/#bass/BASS_DX8_ECHO.html
flanger
Flanger
http://www.un4seen.com/doc/#bass/BASS_DX8_FLANGER.html
gargle
Gargle
http://www.un4seen.com/doc/#bass/BASS_DX8_GARGLE.html
i3dl2reverb
I3DL2 Reverb
I3DL2 (Interactive 3D Audio Level 2) reverberation effect.
http://www.un4seen.com/doc/#bass/BASS_DX8_I3DL2REVERB.html
parameq
Param EQ
Parametric equalizer effect.
http://www.un4seen.com/doc/#bass/BASS_DX8_PARAMEQ.html
reverb
Reverb
http://www.un4seen.com/doc/#bass/BASS_DX8_REVERB.html
TODO
Demo: https://www.youtube.com/watch?v=0sTgpZjRmHQ
Issue #320