Skip to content

Add a new upscaled/remade "Default New" skin as a replica (128x128 -> 128x258) #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 26, 2022
Merged

Add a new upscaled/remade "Default New" skin as a replica (128x128 -> 128x258) #2830

merged 13 commits into from
Dec 26, 2022

Conversation

Haxardous
Copy link
Member

This PR updates the current Default skin with a higher resoultion including remade/upscaled vectors.

("X" button is not part of the skin)*
image
image
image
image
image
image

@Haxardous Haxardous self-assigned this Dec 14, 2022
@Haxardous Haxardous added enhancement New feature or request gui labels Dec 14, 2022
@Haxardous
Copy link
Member Author

The latest commits fixes all the mentioned notes via Development's Discord.

I'll rename the issue to something else, as I have reverted the changes to the Default skin and moved the newer version to a new skin folder "Default New" and set as the new default skin.

image

@Haxardous Haxardous changed the title "Default" skin remake/upscale (128x128 => 128x256) Add a new upscaled/remade "Default New" skin as a replica (128x128 -> 128x258) Dec 20, 2022
Dutchman101
Dutchman101 previously approved these changes Dec 25, 2022
Copy link
Member

@Dutchman101 Dutchman101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it should have been done within this PR (as code review entries), but i come to the conclusion that all concerns, feedback and recommendation from Dev discord since the initial PR has been properly addressed in this one. Including that users who still don't feel comfortable with the rescale can switch back from "Default New" to "Default"

@Dutchman101
Copy link
Member

Dutchman101 commented Dec 25, 2022

As it is now, only fresh installs will use "Default New" skin, and existing installations that have "Default" in coreconfig.xml need to manually switch. I think we can merge this now and use a separate PR to sort that out with a "write setting value once" in a similar way as c6f5ae2 did, while it continues to respect if the user switches back to "Default", so it wont write again. For which the registry or a confirmed-revert flag of some kind can be used, so it continues to only make the change once

@Dutchman101
Copy link
Member

Can we just rename it to "Default 2023", idea from botder

@Haxardous
Copy link
Member Author

Latest commit covers the latests requests, ready to be merged.

@botder botder merged commit 2d9e033 into multitheftauto:master Dec 26, 2022
@botder botder added this to the Next Release (1.6.0) milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants