Skip to content

Fix detection of some dff's #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 22, 2020
Merged

Conversation

TheNormalnij
Copy link
Member

Fix issue #1444
Some DFF's have UV Animation Dictionary RW Section (0x2B). IsDFFData check only 0x10 section and you can't load DFF's with 0x2B section from buffer using engineLoadDFF.

@StrixG StrixG changed the title Fixed detection of some dff's Fix detection of some dff's Jul 22, 2020
@StrixG StrixG linked an issue Jul 22, 2020 that may be closed by this pull request
@StrixG StrixG added the bug Something isn't working label Jul 22, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Does it also fix #981?

@TheNormalnij
Copy link
Member Author

No. It only helps to load a model from a string.

@ghost ghost merged commit cf3608d into multitheftauto:master Jul 22, 2020
@ghost ghost added this to the 1.5.8 milestone Jul 22, 2020
@TheNormalnij TheNormalnij deleted the fix_dff_detect branch July 22, 2020 23:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engineLoadDFF can't load some dff's from buffer.
2 participants