-
-
Notifications
You must be signed in to change notification settings - Fork 464
Implement messageType parameter to onClientChatMessage #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull latest from mtasa-blue/master
Fixed a typo in CClientGame, implemented messageType for onClientChatMessage
as someone said some time ago: enum should be returned as string, not a number |
@CrosRoad95 I have kept this consistent with |
This comment has been minimized.
This comment has been minimized.
I need this for a gamemode I'm working on. Could someone review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bitstream needs bump
This comment has been minimized.
This comment has been minimized.
This reverts commit 8f07b31. Fuck me in the ass with a byte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #1014
This PR adds the
messageType
parameter to theonClientChatMessage
event. The possible types are as follows:0, 1 and 2 follow the same structure as the
onPlayerChat
event.private
type is when using the/msg
commandinternal
is for any messages sent internally by MTA (such as "login: You successfully logged in")I have included a small test script below (clientside)
Also fixed a couple of typos already present in the code.