修复相对路径资源无法正常引入的bug #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchengjian
reviewed
May 5, 2018
| if (firstChar === '.') { | ||
| // 资源路径 | ||
| var assetPath = path.resolve(path.dirname(fileOptions.resourcePath), value) | ||
| // 小于limit的资源转base64 |
There was a problem hiding this comment.
对啦，在小程序里没有必要转 base64 啊。。。一整个就一个离线包，base64 反而可能影响解析速度
There was a problem hiding this comment.
好像是没什么必要，背景图那些这里不会处理到，可以把limit默认设置为0吧
There was a problem hiding this comment.
在css中引入的背景图是url-loader处理的，如果只有base64支持，可以把url-loader的配置limit调大
There was a problem hiding this comment.
背景图我记得好像没问题，字体没试过，理论上应该也可以，不知道为什么之前好多人说这个问题。。
There was a problem hiding this comment.
这里主要是处理 img 标签这类引用相对资源的话，确实不是很有必要转 base64
There was a problem hiding this comment.
BugKun
pushed a commit
to BugKun/mpvue-loader
that referenced
this pull request
Jun 1, 2020
修复相对路径资源无法正常引入的bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aOrz 那个bug没有重现，转base64后应该是没有再copy的，可能是之前留下的，可以先把dist remove掉再试试看有没被copy。另外存在一个bug，在windows下路径解析错误，这里修复了。