Skip to content

[helm] Add volume management, custom labels, environment variables and custom existing secret #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2023
Merged

[helm] Add volume management, custom labels, environment variables and custom existing secret #108

merged 6 commits into from
Feb 24, 2023

Conversation

pauldn-wttj
Copy link
Contributor

Hello, 👋

Thanks for your work on this operator, it's very useful!
We installed it on our EKS cluster using Helm after some tweaking to make it work with AWS-flavored Kubernetes components (most notably the CSI driver for AWS secrets and the CNI), here they are in this PR.

Context

  • When using a secrets CSI driver such as AWS CSI driver, we want to be able to mount volumes with secrets coming from a SecretProviderClass (see documentation), which will create a secret with some needed keys.
  • When using AWS SecurityGroupPolicy, we want to be able to add custom labels onto our pods since it applies to pods with a matchLabels (see documentation)

Changelog

  • Add volumes and volumeMounts in Helm chart, to declare and mount volumes on the pod.
  • Add podLabels to add custom labels on the pod.
  • Add env to specify additional environment variables injected in pod.
  • Add existingSecret to specify an already existing secret where the operator may fetch its environment variables (this will not create a new secret).
  • Add tolerations and nodeSelector to make it possible to manage more precisely where the pods are scheduled.

I am unsure as to how to bump the version.

Let me know if there is anything incorrect, I'll be happy to update it.

Thanks!

Copy link
Member

@hitman99 hitman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@hitman99 hitman99 merged commit 68bdf9d into movetokube:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants