Skip to content

ci: skip flaky tests in FLE test suite #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1561,15 +1561,15 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
keyName: 'foo'
};

it('should fail with no TLS', metadata, async function () {
it.skip('should fail with no TLS', metadata, async function () {
try {
await clientEncryptionNoTls.createDataKey('azure', { masterKey });
expect.fail('it must fail with no tls');
} catch (e) {
//Expect an error indicating TLS handshake failed.
expect(e.cause.message).to.include('certificate required');
}
});
}).skipReason = 'TODO(NODE-6861): fix flaky test';

it('should succeed with valid TLS options', metadata, async function () {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@ describe('Client Side Encryption (Unified)', function () {
if (typeof shouldSkip === 'string') return shouldSkip;
}

const flakyTests = {
'rewrap to azure:name1': 'TODO(NODE-6860): fix flaky tests'
};

const skipReason = flakyTests[description];

if (skipReason) return skipReason;

return isServerless ? 'Unified CSFLE tests to not run on serverless' : false;
}
);
Expand Down