Skip to content

refactor(NODE-5964): clean up prepareHandshakeDocument #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2024
Merged

refactor(NODE-5964): clean up prepareHandshakeDocument #4001

merged 2 commits into from
Feb 23, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Feb 23, 2024 •
edited
Loading

Description

We don't need to pass authProviders to prepareHandshakeDocument(), because it can read ConnectionOptions from AuthContext.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5964

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review February 23, 2024 16:54
@nbbeeken nbbeeken self-requested a review February 23, 2024 17:33
@nbbeeken nbbeeken self-assigned this Feb 23, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 23, 2024
@nbbeeken nbbeeken merged commit 233a2e0 into main Feb 23, 2024
@nbbeeken nbbeeken deleted the NODE-5964-clean-up-prepare-handshake-document branch February 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @nbbeeken