Skip to content

test(NODE-5643): sync connection string spec tests #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

test(NODE-5643): sync connection string spec tests #3997

merged 2 commits into from
Feb 21, 2024

Conversation

durran
Copy link
Member

@durran durran commented Feb 20, 2024 •
edited
Loading

Description

Syncs connection string spec tests to latest.

What is changing?

  • Syncs the connection string spec tests to the most recent in the specifications repo.
  • Note the DRIVERS ticket only mentions 2 tests, but I figured to see if going to latest on all would pass and the other changes did. This then covers NODE-5753 as well
  • Unskipped NODE-3919 test as it passes now, and that ticket was already closed.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5643/NODE-5753/DRIVERS-2679/DRIVERS-2770

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review February 20, 2024 12:37
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Feb 21, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 21, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB removed their assignment Feb 21, 2024
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aditi-khare-mongoDB aditi-khare-mongoDB added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 21, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit b6de209 into main Feb 21, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-5643 branch February 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @baileympearson @aditi-khare-mongoDB