test(NODE-5929): convert txn legacy spec tests #3987
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import * as path from 'path'; | ||
|
|
||
| import { loadSpecTests } from '../../spec'; | ||
| import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner'; | ||
|
|
||
| const SKIPPED_TESTS = [ | ||
| 'callback succeeds after multiple connection errors', | ||
| 'callback is not retried after non-transient error', | ||
| 'callback is not retried after non-transient error (DuplicateKeyError)', | ||
| 'withTransaction succeeds if callback aborts', | ||
| 'unpin after transient error within a transaction', | ||
| 'withTransaction succeeds if callback commits', | ||
| 'withTransaction still succeeds if callback aborts and runs extra op', | ||
| 'withTransaction still succeeds if callback commits and runs extra op', | ||
| 'withTransaction commits after callback returns (second transaction)', | ||
| 'withTransaction commits after callback returns', | ||
| 'withTransaction and no transaction options set', | ||
| 'withTransaction inherits transaction options from defaultTransactionOptions', | ||
| 'withTransaction explicit transaction options override defaultTransactionOptions', | ||
| 'withTransaction explicit transaction options' | ||
| ]; | ||
|
|
||
| describe('Transactions Convenient API Spec Unified Tests', function () { | ||
| beforeEach(function () { | ||
| if (this.configuration.topologyType === 'LoadBalanced') { | ||
| if (this.currentTest) { | ||
| this.currentTest.skipReason = | ||
| 'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.'; | ||
| } | ||
| this.skip(); | ||
| } | ||
| }); | ||
|
|
||
| runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => { | ||
| return SKIPPED_TESTS.includes(test.description) | ||
| ? 'TODO(NODE-5855/DRIVERS-2816): Skipping failing transaction tests' | ||
| : false; | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import * as path from 'path'; | ||
|
|
||
| import { loadSpecTests } from '../../spec'; | ||
| import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner'; | ||
|
|
||
| const SKIPPED_TESTS = [ | ||
| // TODO(NODE-5925) - secondary read preference not allowed in transactions. | ||
| 'readPreference inherited from defaultTransactionOptions', | ||
| // TODO(NODE-5924) - Fix modification of readConcern object post message send. | ||
| 'readConcern local in defaultTransactionOptions', | ||
| 'defaultTransactionOptions override client options', | ||
| 'transaction options inherited from defaultTransactionOptions', | ||
| 'transaction options inherited from client', | ||
| 'causal consistency disabled' | ||
| // TODO(NODE-5855) - Gone away after NODE-5929 | ||
|
There was a problem hiding this comment. The unified tests that are related to NODE-5855 are automatically skipped by the unified tests due to the fact that |
||
| ]; | ||
|
|
||
| describe('Transactions Spec Unified Tests', function () { | ||
| this.beforeEach(function () { | ||
| if (this.configuration.topologyType === 'LoadBalanced') { | ||
| if (this.currentTest) { | ||
| this.currentTest.skipReason = | ||
| 'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.'; | ||
| } | ||
| } | ||
| this.skip(); | ||
| }); | ||
|
|
||
| runUnifiedSuite(loadSpecTests(path.join('transactions', 'unified')), test => { | ||
| return SKIPPED_TESTS.includes(test.description) | ||
| ? 'TODO(NODE-5924/NODE-5925): Skipping failing transaction tests' | ||
| : false; | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I converted the tests to typescript. Unskipped everything and re-verified everything was was getting skipped and filed 2 new tickets (NODE-5925 and NODE-5924) for 2 new bugs these tests exposed in the driver.