Skip to content

test(NODE-5621): unskip and fix the unicode auth prose spec tests #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jan 15, 2024

Description

Unskip and fix the unicode auth prose spec tests.

What is changing?

  • Modify newClient() so that auth credentials that are sent as serverOptions are not overwritten by test configuration auth
  • Modify url() so that auth credentials that are sent as an attribute are not overwritten by test configuration auth
  • The unskipped now check both auth credentials sent as URL (normalized and encoded) and serverOptions (normalized)

Note: We can pass auth credentials as queryOptions (btw I renamed dbOptions to queryOptions, because the naming was misleading) in tests, but those should be not encoded, because otherwise newClient() will run encodeURIComponent() on already encoded values.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5621

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review January 18, 2024 17:03
@durran durran self-assigned this Jan 22, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 22, 2024
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 22, 2024
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken changed the title fix(NODE-5621): unskip and fix the unicode auth prose spec tests test(NODE-5621): unskip and fix the unicode auth prose spec tests Jan 22, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note I changed the PR title, this is a test only change, fix and feat are for changes that bump the driver version.

@durran durran merged commit 7f97c2a into main Jan 22, 2024
@durran durran deleted the NODE-5621-unicode-fail-scram-auth branch January 22, 2024 20:05
aditi-khare-mongoDB pushed a commit that referenced this pull request Jan 25, 2024
)

Co-authored-by: Durran Jordan <durran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants