Skip to content

test(NODE-5724): heartbeat started is emitted before socket is connected #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 18, 2024
Merged

test(NODE-5724): heartbeat started is emitted before socket is connected #3960

merged 9 commits into from
Jan 18, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 8, 2024 •
edited by nbbeeken
Loading

Description

What is changing?

Implement spec test added in DRIVERS-2677

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5724

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken
nbbeeken reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! a few clean up ideas

@W-A-James W-A-James changed the title Driver 2677 poc test(NODE-5724): Implement new sdam prose test Jan 17, 2024
@W-A-James
Copy link
Contributor Author

Note: Bug ticket NODE-5840 filed to address incorrect heartbeat duration measurement

@W-A-James W-A-James marked this pull request as ready for review January 17, 2024 18:43
@nbbeeken nbbeeken self-assigned this Jan 17, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 17, 2024
nbbeeken
nbbeeken suggested changes Jan 17, 2024
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken January 18, 2024 15:08
@nbbeeken nbbeeken changed the title test(NODE-5724): Implement new sdam prose test test(NODE-5724): heartbeat started is emitted before socket is connected Jan 18, 2024
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 18, 2024
@nbbeeken
Copy link
Contributor

Will merge soon, just double checking some new setup failures that I think are transient

@nbbeeken nbbeeken merged commit 4e56482 into main Jan 18, 2024
@nbbeeken nbbeeken deleted the DRIVER-2677-POC branch January 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken