Skip to content

refactor(NODE-5743): use new connection #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 20, 2023
Merged

refactor(NODE-5743): use new connection #3952

merged 15 commits into from
Dec 20, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 15, 2023 •
edited
Loading

Description

What is changing?

  • Removes old connection layer
  • Renames commandAsync to command
  • Replaces symbol properties on Connection class with strings
  • Add access modifiers to all properties and methods
  • Remove EVG variant testing "new connection"
Is there new documentation needed for these changes?

None.

What is the motivation for this change?

This PR goes a bit beyond just migrating us to the new layer, but the symbol changes and access modifier changes are low hanging fruit we can pull in as a part of migrating to what we consider "modern" code.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title NODE-5743-use-new-connection refactor(NODE-5743): use new connection Dec 15, 2023
Base automatically changed from NODE-5771-perf-new-connection to main December 19, 2023 19:27
@nbbeeken nbbeeken force-pushed the NODE-5743-use-new-connection branch from 5fb852b to f81e8b7 Compare December 19, 2023 19:40
@nbbeeken nbbeeken force-pushed the NODE-5743-use-new-connection branch from ca28648 to 11259dd Compare December 20, 2023 16:24
@nbbeeken nbbeeken marked this pull request as ready for review December 20, 2023 18:51
@durran durran self-assigned this Dec 20, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 20, 2023
durran
durran approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing so much code removed. Nice work.

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 20, 2023
@durran durran merged commit efece79 into main Dec 20, 2023
@durran durran deleted the NODE-5743-use-new-connection branch December 20, 2023 22:20
aditi-khare-mongoDB pushed a commit that referenced this pull request Dec 21, 2023
@nbbeeken @aditi-khare-mongoDB
refactor(NODE-5743): use new connection (#3952)
0678efc
aditi-khare-mongoDB pushed a commit that referenced this pull request Dec 21, 2023
@nbbeeken @aditi-khare-mongoDB
refactor(NODE-5743): use new connection (#3952)
0416fc9
aditi-khare-mongoDB pushed a commit that referenced this pull request Dec 21, 2023
@nbbeeken @aditi-khare-mongoDB
refactor(NODE-5743): use new connection (#3952)
b7ab626
@trentm trentm mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran