chore(NODE-5776): track aws credential as a devDep in addtion to peerDep #3939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
alenakhineika
added
the
Primary Review
|
Is there any AC for this PR since it is a sub-task of NODE-5710? The PR looks good in isolation. |
|
Nothing different than the parent: add the dev dep, and fix the test variants. There's a kickoff linked on the parent with implementation details if you want to review that. |
alenakhineika
added
Team Review
W-A-James
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Track aws sdk in dev deps and skip aws auth tests that do not work without SDK
Is there new documentation needed for these changes?
No
What is the motivation for this change?
This is to control which version we test with so we can remove vulnerable versions from our matrix
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript