Skip to content

test(NODE-5761): skip azure oidc tests #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

test(NODE-5761): skip azure oidc tests #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4514,12 +4514,6 @@ buildvariants:
tasks:
- test_azurekms_task_group
- test-azurekms-fail-task
- name: ubuntu20-test-azure-oidc
display_name: Azure OIDC
run_on: ubuntu2004-small
batchtime: 20160
tasks:
- testazureoidc_task_group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason a similar TODO(DRIVERS-2416/NODE4929) comment wasn't left in this file? Is it just assumed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.yml is generated from config.in.yml so the comments get filtered out. So we put them always in config.in.yml which is the file we edit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, apologies for the delay in responding. LGTM

- name: rhel8-test-atlas
display_name: Atlas Cluster Tests
run_on: rhel80-large
Expand Down
17 changes: 10 additions & 7 deletions .evergreen/generate_evergreen_tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,13 +700,16 @@ BUILD_VARIANTS.push({
tasks: ['test_azurekms_task_group', 'test-azurekms-fail-task']
});

BUILD_VARIANTS.push({
name: 'ubuntu20-test-azure-oidc',
display_name: 'Azure OIDC',
run_on: UBUNTU_20_OS,
batchtime: 20160,
tasks: ['testazureoidc_task_group']
});
// TODO(DRIVERS-2416/NODE-4929) - Azure credentials are expired, a new drivers ticket
// should be created but at the moment for our test failures we will reference the
// open DRIVERS ticket and completed NODE ticket.
// BUILD_VARIANTS.push({
// name: 'ubuntu20-test-azure-oidc',
// display_name: 'Azure OIDC',
// run_on: UBUNTU_20_OS,
// batchtime: 20160,
// tasks: ['testazureoidc_task_group']
// });

BUILD_VARIANTS.push({
name: 'rhel8-test-atlas',
Expand Down