Skip to content

refactor(NODE-5741): use async io helpers #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
6d62616
refactor(NODE-5741): use async io helpers
nbbeeken Nov 16, 2023
0994beb
refactor: move command preparing to helper
nbbeeken Nov 16, 2023
8f3d6df
refactor: make command async
nbbeeken Nov 16, 2023
6b97abc
refactor: add sendCommand helper for send and recv
nbbeeken Nov 16, 2023
114ec14
refactor: remove onMessage
nbbeeken Nov 16, 2023
d08f985
refactor: remove message stream
nbbeeken Nov 16, 2023
4d9c5f6
refactor: update cleanup method
nbbeeken Nov 16, 2023
9414f0a
refactor: remove force flag and support noResponse
nbbeeken Nov 16, 2023
3080752
refactor: remove drain event listener
nbbeeken Nov 16, 2023
aa9a655
refactor: connect error handling to signal
nbbeeken Nov 17, 2023
b816ce1
test: add new variants enabling ModernConnection
nbbeeken Nov 17, 2023
8724375
refactor: re-introduce listeners for signal aborting with error
nbbeeken Nov 17, 2023
afd396f
test: set env variable for new connection tests
nbbeeken Nov 17, 2023
88da43d
test: fix utf8 validation option tests
nbbeeken Nov 17, 2023
23b9f7f
test: session usage back down to 1! woo!
nbbeeken Nov 17, 2023
97b8ff3
test: fix spec auth test to spy on correct connection class
nbbeeken Nov 17, 2023
3a8275f
test: latest lts avoiding npm install issue
nbbeeken Nov 17, 2023
771d913
test: fix unit tests, skip i/o helpers temporarily
nbbeeken Nov 18, 2023
cbaa60d
test: fix lint, unit stub of command, delayedTimeout
nbbeeken Nov 20, 2023
c179bdd
chore: unset FLE variable on windows
nbbeeken Nov 20, 2023
e2338d7
refactor: fix closed condition
nbbeeken Nov 20, 2023
3d2ca60
refactor: fix closed condition
nbbeeken Nov 20, 2023
5b3d350
test: catch ns not found
nbbeeken Nov 20, 2023
8480f07
revert: parseBsonSerializationOptions this type
nbbeeken Nov 21, 2023
8239321
refactor: improve aborted and add tests
nbbeeken Nov 21, 2023
0805ef8
fix: lint and node 16 unit
nbbeeken Nov 21, 2023
0778c86
refactor: remove throwIfAborted
nbbeeken Nov 22, 2023
a8fea73
docs: add comment about abort listener
nbbeeken Nov 22, 2023
3fe7dfd
fix: command monitoring for io failures
nbbeeken Nov 22, 2023
303e2e9
fix: command monitoring if stmt
nbbeeken Nov 22, 2023
8f5be31
test: remove ModernConnection unit tests
nbbeeken Nov 28, 2023
150d9d6
refactor: add abortable helper
nbbeeken Nov 28, 2023
04c261f
chore: add todo
nbbeeken Nov 29, 2023
6285272
test: fix unit tests
nbbeeken Nov 29, 2023
effa155
docs: add util docs
nbbeeken Nov 29, 2023
9347327
daria: fixes
nbbeeken Dec 1, 2023
f7da810
daria: depluralize
nbbeeken Dec 1, 2023
9476230
ci: only specify needed var
nbbeeken Dec 1, 2023
9939dfe
docs: improved for abortable
nbbeeken Dec 1, 2023
6315e0e
test: complete coverage of abortable helper
nbbeeken Dec 1, 2023
56c97c7
Merge branch 'main' into NODE-5741-use-io-async
nbbeeken Dec 1, 2023
ccf3d2d
daria: fix
nbbeeken Dec 1, 2023
d49ef29
chore: test and noResponse
nbbeeken Dec 1, 2023
5602453
lint: imports
nbbeeken Dec 1, 2023
293a46a
daria: test title improvements
nbbeeken Dec 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .evergreen/config.in.yml
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ functions:
type: test
params:
working_dir: "src"
env:
MONGODB_NEW_CONNECTION: ${MONGODB_NEW_CONNECTION|false}
timeout_secs: 300
shell: bash
script: |
Expand Down
38 changes: 38 additions & 0 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ functions:
type: test
params:
working_dir: src
env:
MONGODB_NEW_CONNECTION: ${MONGODB_NEW_CONNECTION|false}
timeout_secs: 300
shell: bash
script: |
Expand Down Expand Up @@ -4552,6 +4554,42 @@ buildvariants:
- test-3.6-server-noauth
- test-3.6-replica_set-noauth
- test-3.6-sharded_cluster-noauth
- name: rhel8-new-connection-tests
display_name: New Connection Tests
run_on: rhel80-large
expansions:
NODE_LTS_VERSION: 20
CLIENT_ENCRYPTION: true
MONGODB_NEW_CONNECTION: true
tasks:
- test-latest-server
- test-latest-replica_set
- test-latest-sharded_cluster
- test-rapid-server
- test-rapid-replica_set
- test-rapid-sharded_cluster
- test-7.0-server
- test-7.0-replica_set
- test-7.0-sharded_cluster
- test-6.0-server
- test-6.0-replica_set
- test-6.0-sharded_cluster
- test-5.0-server
- test-5.0-replica_set
- test-5.0-sharded_cluster
- test-4.4-server
- test-4.4-replica_set
- test-4.4-sharded_cluster
- test-4.2-server
- test-4.2-replica_set
- test-4.2-sharded_cluster
- test-4.0-server
- test-4.0-replica_set
- test-4.0-sharded_cluster
- test-3.6-server
- test-3.6-replica_set
- test-3.6-sharded_cluster
- test-latest-server-v1-api
- name: rhel8-test-lambda
display_name: AWS Lambda handler tests
run_on: rhel80-large
Expand Down
12 changes: 12 additions & 0 deletions .evergreen/generate_evergreen_tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,18 @@ BUILD_VARIANTS.push({
tasks: AUTH_DISABLED_TASKS.map(({ name }) => name)
});

BUILD_VARIANTS.push({
name: 'rhel8-new-connection-tests',
display_name: 'New Connection Tests',
run_on: DEFAULT_OS,
expansions: {
NODE_LTS_VERSION: LATEST_LTS,
CLIENT_ENCRYPTION: true,
MONGODB_NEW_CONNECTION: true
},
tasks: BASE_TASKS.map(({ name }) => name)
});

BUILD_VARIANTS.push({
name: 'rhel8-test-lambda',
display_name: 'AWS Lambda handler tests',
Expand Down
1 change: 1 addition & 0 deletions .evergreen/run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,5 @@ export MONGODB_URI=${MONGODB_URI}
export LOAD_BALANCER=${LOAD_BALANCER}
export TEST_CSFLE=${TEST_CSFLE}
export COMPRESSOR=${COMPRESSOR}
export MONGODB_NEW_CONNECTION=${MONGODB_NEW_CONNECTION}
npm run "${TEST_NPM_SCRIPT}"
Loading