Skip to content

ci(NODE-5424): add CI testing for FLE 6.0 with driver latest #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 8, 2023

Description

What is changing?

To prepare for the 6.0 release and the compatabilty matrix between mongodb-client-encryption and the driver, I added a task to our CI that tests the latest driver changes against mongodb-client-encryption@6.0.0. This task runs for all regular CI runs as a part of the custom csfle tests.

I also pulled in the latest alpha of mongodb-client-encryption for all CI runs except the new variant.

To confirm that the new task was running against the correct version of mongodb-client-encryption, I added the version of mongodb-client-encryption used (if it's available) to the printout before mocha CI runs. This affects all CI runs but I believe this is a useful improvement. Here is an example: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel80_large_Node20_test_4.4_sharded_cluster_patch_51a573fe99506b81c7ab808898eb9eb63f58f600_64d3af041e2d171079fd9bc0_23_08_09_15_21_41/0/task?bookmarks=0,7369&shareLine=545

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review August 9, 2023 14:31
@durran durran self-assigned this Aug 10, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 10, 2023
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AC for the JIRA ticket has the entire matrix there, but we have not released a 6.0 driver yet and have no 6.0 branch. Should we move that to another follow up ticket post 6.0 and have this one be driver latest/FLE 6.0 and driver latest/FLE latest?

@baileympearson
Copy link
Contributor Author

baileympearson commented Aug 10, 2023

After https://mongodb.slack.com/archives/GGWBN4ZNK/p1691521646939079, I created the 6.0 branch. We'll just need to rebase it once 6.0 is released.

You can see it's already running CI when libmongocrypt commits. The only task left (and something I had to ask the evergreen team for help for) was limiting which tasks run on the waterfall to only the custom csfle tests.

evergreen project: https://spruce.mongodb.com/commits/node-mongodb-native-6.0?view=FAILED

@durran

@durran durran self-requested a review August 10, 2023 14:50
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I can see them running on the 6.x branch now, thanks for the link.

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 10, 2023
@durran durran merged commit 6b7e186 into mongodb:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants