refactor(NODE-5473): Remove Unused Callback Inheritance in Operations Layer #3793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed callback class from AbstractOp and CommandOp
nbbeeken
suggested changes
Aug 2, 2023
nbbeeken
added
the
Primary Review
added override and async keywords
nbbeeken
approved these changes
Aug 3, 2023
malikj2000
added a commit
that referenced
this pull request
Aug 3, 2023
malikj2000
added a commit
that referenced
this pull request
Aug 3, 2023
malikj2000
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removed unused callback inheritance in all operation files
What is changing?
asyncified eval.ts
removed unimplemented executeCallback method from all operation files
removed callback classes from AbstractOperation and CommandOperation
Is there new documentation needed for these changes?
None
What is the motivation for this change?
further asyncifying the driver
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript