refactor(NODE-5422): convert FLE kms providers and errors to Typescript #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
typescript-kms-providers-logic
branch
from
4998992 to
5d6d767
Compare
baileympearson
force-pushed
the
typescript-kms-providers-logic
branch
from
d322be9 to
1a0af79
Compare
baileympearson
commented
Jul 24, 2023
baileympearson
commented
Jul 24, 2023
baileympearson
commented
Jul 24, 2023
nbbeeken
added
the
Primary Review
baileympearson
changed the title
nbbeeken
suggested changes
Jul 24, 2023
nbbeeken
reviewed
Jul 24, 2023
nbbeeken
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The first half of FLE code has been converted to TS and integrated into the driver. Specifically, the kms credential refresh logic and the errors. This PR adds
gcp-metadataas an optional dependency to enable gcp credential refreshing for FLE.The failing dependency check action is expected, because we have not released a 6.0 major of
mongodb-client-encryptionyet.Is there new documentation needed for these changes?
No.
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript