refactor(NODE-5360): refactor CommandOperation to use async #3749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Jun 30, 2023
nbbeeken
suggested changes
Jul 6, 2023
nbbeeken
suggested changes
Jul 6, 2023
nbbeeken
added
Team Review
added CommandCallbackOperation class changed executeCommand to executeCommandCallback
modified inheritance to CommandCallbackOperation
executeCallbackCommand now invokes executeCommand
nbbeeken
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactored CommandOperation class to use async
modified all calls to CommandOperation to call CommandCallbackOperation instead
What is changing?
new class CommandCallbackOperation
operations now subclass CommandCallbackOperation
new tests
Is there new documentation needed for these changes?
What is the motivation for this change?
refactoring operations layer to use async/await
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript