Skip to content

test(NODE-5327): fix handling of embedded nulls in spec runner matcher #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 20, 2023

Conversation

durran
Copy link
Member

@durran durran commented Jun 15, 2023

Description

Updates the spec test runner matcher to handle null or root fields and embedded fields differently.

What is changing?

  • Allows for a root field in a matcher defined in the spec assertion as null to match on both null or undefined.
  • Changes embedded field assertions to test for exact matches.

With this change, here is a patch showing the expected ecc collection assertions would have failed before they were removed: https://spruce.mongodb.com/task/mongo_node_driver_next_rhel80_large_Node20_test_7.0_sharded_cluster_patch_dc068ac1f6e91794836e103f8a06c2580405ad76_648c8bd132f4173ed7500378_23_06_16_16_20_34/tests?execution=0&sortBy=STATUS&sortDir=ASC

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5327

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 19, 2023 15:59
@durran durran changed the title test(NODE-5327): debug test runner test(NODE-5327): fix handling of embedded nulls in spec runner matcher Jun 20, 2023
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 20, 2023
@baileympearson baileympearson self-assigned this Jun 20, 2023
@baileympearson baileympearson merged commit dc464c6 into main Jun 20, 2023
@baileympearson baileympearson deleted the NODE-5327 branch June 20, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants