Skip to content

test(NODE-4708): add rewrapmanydatakey prose test 2 #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

test(NODE-4708): add rewrapmanydatakey prose test 2 #3685

merged 1 commit into from
May 26, 2023

Conversation

durran
Copy link
Member

@durran durran commented May 26, 2023

Description

Adds prose test #2 for RewrapManyDataKey.

What is changing?

  • Adds the second prose test and asserts that it raises an error.
  • Bindings throw a type error with the message "expected UTF-8 provider" - no bindings changes needed.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4708 / DRIVERS-2441

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson merged commit 436dc9c into main May 26, 2023
@baileympearson baileympearson deleted the NODE-4708 branch May 26, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @baileympearson