ci(NODE-4698): test csfle with mongocryptd #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
May 25, 2023
Comment on lines
466
to
469
| .filter((mongoVersion) => { // Only run on server versions >= 4.2 | ||
| const numericVersion = Number(mongoVersion); | ||
| return !Number.isNaN(numericVersion) && numericVersion >= 4.2; | ||
| }) |
There was a problem hiding this comment.
We actually have a package called semver that we use for version comparison:
also, I think we should test on latest / rapid as well
Suggested change
| .filter((mongoVersion) => { // Only run on server versions >= 4.2 | |
| const numericVersion = Number(mongoVersion); | |
| return !Number.isNaN(numericVersion) && numericVersion >= 4.2; | |
| }) | |
| .filter((version) => ['latest', 'rapid'].includes(version) || semver.gte(version, '4.2')) |
baileympearson
approved these changes
May 26, 2023
baileympearson
deleted the
NODE-4698/test_crypt_shared_with_older_server_versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Summary
Adding new CI variants to run CSFLE tests with mongocryptd instead of crypt_shared, which we already had coverage for.
changes to
config.in.yml.evergreen/prepare-crypt-shared-lib.shTEST_NPM_SCRIPTenv variablechanges to
generate_evergreen_tasks.jsIs there new documentation needed for these changes?
No
What is the motivation for this change?
Spec compliance
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript