-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-5262, NODE-5311): batch backport #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
added a commit
to baileympearson/node-mongodb-native
that referenced
this pull request
May 25, 2023
baileympearson
pushed a commit
to baileympearson/node-mongodb-native
that referenced
this pull request
May 25, 2023
baileympearson
added a commit
to baileympearson/node-mongodb-native
that referenced
this pull request
May 25, 2023
aa236d5
to
6e3a374
Compare
baileympearson
added a commit
that referenced
this pull request
May 25, 2023
baileympearson
pushed a commit
that referenced
this pull request
May 25, 2023
baileympearson
added a commit
that referenced
this pull request
May 25, 2023
6e3a374
to
acaf1a0
Compare
baileympearson
added a commit
that referenced
this pull request
May 25, 2023
acaf1a0
to
ba20eca
Compare
durran
approved these changes
May 26, 2023
dariakp
reviewed
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that merge commit going to show up on 4.x if you do the rebase/fast-forward?
ed9a937
to
f4e31ba
Compare
durran
pushed a commit
that referenced
this pull request
May 26, 2023
durran
pushed a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Backports #3663 and #3682.
Also updates CI scripts to pull in mongodb-client-encryption@2.8.0.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript