Skip to content

test(NODE-2422): Validate that mongocryptd is not spawned if bypassAutoEncryption=true #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 16, 2023
Merged

test(NODE-2422): Validate that mongocryptd is not spawned if bypassAutoEncryption=true #3662

merged 13 commits into from
May 16, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented May 4, 2023 •
edited
Loading

Description

What is changing?

  • implement spec tests for bypassing spawning mongocryptd
Is there new documentation needed for these changes?
  • no

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title test(NODE-2422): add new tests test(NODE-2422): Validate that mongocryptd is not spawned if bypassAutoEncryption=true May 4, 2023
@W-A-James W-A-James marked this pull request as ready for review May 4, 2023 20:30
@W-A-James W-A-James added the Blocked Blocked on other work label May 5, 2023
Base automatically changed from NODE-4772/test_mongocryptd_not_spawned_when_shlib_loaded to main May 11, 2023 15:46
@baileympearson baileympearson removed the Blocked Blocked on other work label May 15, 2023
@baileympearson baileympearson added the Team Review Needs review from team label May 15, 2023
baileympearson
baileympearson previously approved these changes May 15, 2023
View reviewed changes
durran
durran previously approved these changes May 15, 2023
View reviewed changes
dariakp
dariakp requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of failing tests on this PR specifically, have they all been reviewed?

@baileympearson baileympearson dismissed stale reviews from durran and themself via 4bb50dd May 15, 2023 20:59
dariakp
dariakp approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all the CI failures are accounted for

@durran
Copy link
Member

durran commented May 16, 2023

Win/Node 14 issues unrelated to this PR.

@durran durran merged commit adef3f7 into main May 16, 2023
@durran durran deleted the NODE-2422/validate_that_mongocryptd_not_spawned_if_bypassAutoEncrypt_is_true branch May 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@durran durran durran left review comments

@baileympearson baileympearson baileympearson left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@W-A-James @durran @baileympearson @dariakp