test(NODE-4772): Test that mongocryptd is not spawned when shared library is loaded #3661
Conversation
W-A-James
changed the title
baileympearson
added
the
Primary Review
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Show resolved
Hide resolved
.evergreen/run-kms-servers.sh
Outdated
There was a problem hiding this comment.
did you mean to change this file?
There was a problem hiding this comment.
Yes, this was intentional. It didn't have execute permissions by default and whenever I test locally, I have to give it execute permissions, so I updated that here. I can add it to the "What is changing?" section of the PR description.
There was a problem hiding this comment.
Any other reason you can't just bash .evergreen/run-kms-servers.sh? I'm not opposed to adding execute permissions but we don't have them currently because in CI we intentionally run these scripts with bash because the default shell in evergreen is different on different hosts.
I was also confused by the changes because I thought Github was displaying the file size, not the permissions
There was a problem hiding this comment.
No other reason than convenience.
On further inspection, if we're going to keep the permissions change, we should also add a shebang line to the top of that file so if it is invoked with ./.evergreen/run-kms-servers.sh it uses bash automatically.
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
….prose.test.js Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
…d' of github.com:mongodb/node-mongodb-native into NODE-4772/test_mongocryptd_not_spawned_when_shlib_loaded
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
baileympearson
deleted the
NODE-4772/test_mongocryptd_not_spawned_when_shlib_loaded
branch
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Ensuring we keep up with spec.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript