Skip to content

chore(NODE-5247): update dependencies #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2023
Merged

chore(NODE-5247): update dependencies #3657

merged 4 commits into from
May 9, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 3, 2023

Description

What is changing?

See https://jira.mongodb.org/browse/NODE-5247

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 4, 2023 21:38
@W-A-James W-A-James self-assigned this May 5, 2023
W-A-James
W-A-James reviewed May 5, 2023
View reviewed changes
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 5, 2023
W-A-James
W-A-James previously approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failures unrelated.

@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 5, 2023
@W-A-James W-A-James self-requested a review May 8, 2023 17:05
W-A-James
W-A-James reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to review CI failures. In specific: https://spruce.mongodb.com/task/mongo_node_driver_rhel80_large_erbium_test_latest_server_patch_bf92d108e5326a835fe14b27e138dcba77b662b5_6453f85cc9ec443ff11239c0_23_05_04_18_24_30/tests?execution=1&sortBy=STATUS&sortDir=ASC

@nbbeeken nbbeeken requested a review from W-A-James May 8, 2023 19:42
@W-A-James W-A-James merged commit 536e6a1 into 4.x May 9, 2023
@W-A-James W-A-James deleted the NODE-5239-deps-4.x branch May 9, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @W-A-James