Skip to content

chore(NODE-5133): remove broken filter as binary from find operation #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Apr 13, 2023

Description

What is changing?

Logic to support Binary objects as filter predicates has been removed from the find operation.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 14, 2023
@durran durran self-assigned this Apr 14, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 17, 2023
@durran durran removed their assignment Apr 17, 2023
@durran durran merged commit aa4f5c0 into main Apr 17, 2023
@durran durran deleted the NODE-5133 branch April 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants