Skip to content

chore(NODE-5128): add script to clean dts and dts.map files #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2023
Merged

chore(NODE-5128): add script to clean dts and dts.map files #3606

merged 2 commits into from
Mar 21, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 20, 2023 •
edited
Loading

Description

What is changing?

Remove rimraf as a dependency and implement a script on node std lib APIs that remove the definition files and maps from our lib directory.

What is the motivation for this change?

  • one less dep
  • globbing stopped working

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 21, 2023 14:14
nbbeeken
nbbeeken commented Mar 21, 2023
View reviewed changes
@baileympearson baileympearson self-assigned this Mar 21, 2023
@baileympearson baileympearson added the Team Review Needs review from team label Mar 21, 2023
@baileympearson baileympearson merged commit 054872d into main Mar 21, 2023
@baileympearson baileympearson deleted the NODE-5128-rm-dts-files branch March 21, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson