Skip to content

ci(NODE-5110): update curl flags #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2023
Merged

ci(NODE-5110): update curl flags #3598

merged 6 commits into from
Mar 14, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 14, 2023 •
edited
Loading

Description

What is changing?

Added Curl flags

  • compressed - should fetch compressed data
  • location - will follow redirects
  • continue-at - will resume interrupted downloads

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 14, 2023 15:46
durran
durran reviewed Mar 14, 2023
View reviewed changes
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 14, 2023
@durran durran self-assigned this Mar 14, 2023
@durran
Copy link
Member

durran commented Mar 14, 2023

Created NODE-5112 for OIDC failures.

durran
durran approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 14, 2023
@durran durran merged commit 42d72b7 into main Mar 14, 2023
@durran durran deleted the NODE-5110 branch March 14, 2023 17:49
baileympearson added a commit that referenced this pull request Mar 14, 2023
@baileympearson
Revert "ci(NODE-5110): update curl flags (#3598)"
1f8459a 
This reverts commit 42d72b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran