Skip to content

refactor(NODE-4904): change internal gridfs logic to use promises #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 22, 2022
Merged

refactor(NODE-4904): change internal gridfs logic to use promises #3493

merged 4 commits into from
Dec 22, 2022

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Refactor GridFS internals to use promises

What is the motivation for this change?

Isolate the changes needed for callback removals.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Dec 21, 2022
Merged
5 tasks
@nbbeeken nbbeeken marked this pull request as ready for review December 21, 2022 16:02
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 21, 2022
@durran durran self-requested a review December 21, 2022 18:38
@durran durran merged commit 9cfa2af into main Dec 22, 2022
@durran durran deleted the NODE-4904-gridfs-promises branch December 22, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran