ci(NODE-4881): adjust tests to pass on Node18 #3485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-4881-fix-driver-ci-node18
branch
from
dc2c1b7 to
80381bc
Compare
baileympearson
force-pushed
the
NODE-4881-fix-driver-ci-node18
branch
from
be6e10d to
f2446ba
Compare
baileympearson
changed the title
addaleax
reviewed
Dec 16, 2022
| @@ -30,7 +31,7 @@ describe('Atlas Data Lake - prose', function () { | |||
| * If a driver constructs and issues killCursors commands in other ways (e.g. public API), this test MUST be adapted to test all such code paths. | |||
| */ | |||
| it('1. Test that the driver properly constructs and issues a killCursors command to Atlas Data Lake.', async function () { | |||
| client = new MongoClient('mongodb://mhuser:pencil@localhost'); | |||
| client = new MongoClient('mongodb://mhuser:pencil@localhost', { family: 4 }); | |||
There was a problem hiding this comment.
Do you want to leave comments (maybe even with a TODO here) to switch this over to happy eyeballs once the driver supports a Node.js version that has it?
nbbeeken
added
the
Primary Review
nbbeeken
reviewed
Dec 16, 2022
test/integration/server-selection/server_selection.prose.operation_count.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
previously approved these changes
Dec 16, 2022
nbbeeken
added
Team Review
nbbeeken
approved these changes
Dec 16, 2022
durran
approved these changes
Dec 19, 2022
baileympearson
added a commit
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Most tests are made to pass by either setting the family to 4 directly on the mongo client, or by setting the default dns resolution order.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript