Skip to content

test(NODE-4574): skip zstd and snappy on gallium #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2022
Merged

test(NODE-4574): skip zstd and snappy on gallium #3379

merged 2 commits into from
Aug 24, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 22, 2022 •
edited
Loading

Description

What is changing?

Skipping compression tests on gallium because of .end() hang
see NODE-4575 for followup

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4574/skip-compression-node16 branch from 4e00057 to f93ab6d Compare August 22, 2022 21:29
@nbbeeken nbbeeken marked this pull request as ready for review August 22, 2022 21:29
baileympearson
baileympearson reviewed Aug 23, 2022
View reviewed changes
baileympearson
baileympearson reviewed Aug 23, 2022
View reviewed changes
baileympearson
baileympearson requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 23, 2022
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 23, 2022
@baileympearson baileympearson merged commit 2eb68e6 into main Aug 24, 2022
@baileympearson baileympearson deleted the NODE-4574/skip-compression-node16 branch August 24, 2022 16:01
durran pushed a commit that referenced this pull request Aug 30, 2022
@nbbeeken @durran
test(NODE-4574): skip zstd and snappy on gallium (#3379)
2430b76
durran pushed a commit that referenced this pull request Aug 31, 2022
@nbbeeken @durran
test(NODE-4574): skip zstd and snappy on gallium (#3379)
168a9ec
baileympearson pushed a commit that referenced this pull request Aug 31, 2022
@nbbeeken @baileympearson
test(NODE-4574): skip zstd and snappy on gallium (#3379)
b643731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @baileympearson