-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-4160): add aws lambda examples #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69c6e3b
to
e1d2e4f
Compare
e1d2e4f
to
659438d
Compare
baileympearson
requested changes
Aug 22, 2022
This reverts commit ce71d5c.
baileympearson
requested changes
Aug 30, 2022
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
baileympearson
previously approved these changes
Aug 30, 2022
nbbeeken
suggested changes
Aug 30, 2022
nbbeeken
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
baileympearson
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds examples for using the Node.js driver with AWS Lambda based on the MongoDB examples in the docs here. Note that there is a slight difference in behaviour as the docs add an additional token in the auth mechanism that is not needed, and they only ask for the database name which doesn't actually do anything server side. I've changed here to just list databases in both examples.
Here are the specific tests passing on evg
What is changing?
test/examples
directory for the code examples.check:lambda
andcheck:lambda:aws
to run the former with no auth and later with AWS auth.handler.js
for no auth andaws_handler.js
for AWS auth.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4160
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>