test(NODE-2556): add integration testing for listDatabases' authorizedDatabases flag #3101

syz99 · 2022-01-11T18:32:06Z

Description

added int tests for the authorizedDatabases option of listDatabases

What is changing?

a new enumerating-databases int test folder with a list_databases test file has been added with appropriate tests

drive-by deletion/cleanup of gitkeep files

Is there new documentation needed for these changes?

n/a

Double check the following

Ran npm run check:lint script
Self-review completed using the steps outlined here
PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
Changes are covered by tests
New TODOs have a related JIRA ticket

nbbeeken

Nice work!

test/integration/enumerating-databases/list_databases.test.ts

nbbeeken

seems like there's a lint check issue and we need the skip back

test/integration/enumerating-databases/list_databases.test.ts

test/integration/enumerate_databases.test.ts

dariakp

In addition to the comments regarding the test structure, please do not delete the .gitkeep files. The idea behind them is to make sure that the spec-related folders exist even if there are no files in them, so even if for the folders with files present we don't want to accidentally delete the folder by moving its contents elsewhere.

test/integration/enumerate_databases.test.ts

syz99 · 2022-01-18T15:51:09Z

Offloading ticket now. PR could be paused since a few new TODO's needed, namely: (1) testing for no duplicates and (2) verifying listDatabases return type is an array (i.e. verifying an "Iterable of Document types" per the spec).

Scope for this PR is to complete Test Case 1 here.

test/integration/enumerate_databases.test.ts

test/integration/enumerate_databases/enumerate_databases.prose.test.ts

baileympearson · 2022-01-24T14:44:00Z

test/integration/enumerate_databases/enumerate_databases.prose.test.ts

+
+    await client.db(DB_NAME).createCollection(DB_NAME);
+
+    ENTIRE_DB_LIST = (await client.db('admin').command({ listDatabases: 1 })).databases.map(


non-blocking: we could use nameOnly here so we don't have to map ({ name }) => name later on

nameOnly: true returns in the shape of:

{ databases: [ { name: 'admin' }, { name: 'config' }, { name: 'local' } ], ok: 1 }

So nothing would change, it omits the metadata from each db description object reducing the BSON transmitted

baileympearson · 2022-01-24T15:02:27Z

I left one small comment but it's non-blocking. LGTM

dariakp

Just one small thing

test/integration/enumerate_databases/enumerate_databases.prose.test.ts

dariakp

LGTM, tyvm :)

syz99 self-assigned this Jan 11, 2022

syz99 requested a review from nbbeeken January 11, 2022 19:59

syz99 force-pushed the NODE-2556/support-authorizedDatabses-flag branch from 642c9b0 to cc7f92a Compare January 11, 2022 20:34

nbbeeken suggested changes Jan 11, 2022

View reviewed changes

nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 11, 2022

nbbeeken suggested changes Jan 11, 2022

View reviewed changes

test/integration/enumerating-databases/list_databases.test.ts Outdated Show resolved Hide resolved

nbbeeken suggested changes Jan 11, 2022

View reviewed changes

test/integration/enumerating-databases/list_databases.test.ts Outdated Show resolved Hide resolved

nbbeeken requested review from durran, baileympearson and dariakp January 11, 2022 23:07

nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 11, 2022

baileympearson reviewed Jan 12, 2022

View reviewed changes

test/integration/enumerating-databases/list_databases.test.ts Outdated Show resolved Hide resolved

nbbeeken previously approved these changes Jan 12, 2022

View reviewed changes

syz99 dismissed nbbeeken’s stale review via 389746e January 12, 2022 16:36

baileympearson reviewed Jan 12, 2022

View reviewed changes

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

dariakp requested changes Jan 12, 2022

View reviewed changes

syz99 added 12 commits January 18, 2022 11:24

add new test file + cleanup .gitkeeps

0ad45e1

new test case

750b628

cleanup clients

76ac4b7

update userOptions

45a3454

add test assertions for db existence

3f4a4cc

add skip for no 'auth' flag in cluster setup

95ab95d

uncomment

4d2d7f5

remove auth flag in setup script

5f3a9e6

add comments / cleanup tests

3d23013

add skip back

bba4659

refactor folder/file structure to match spec

795751d

add gitkeeps back to int tests

db4bc71

test: add spec test plan prose

a367230

nbbeeken force-pushed the NODE-2556/support-authorizedDatabses-flag branch from 48cb739 to a367230 Compare January 18, 2022 17:03

nbbeeken requested a review from dariakp January 18, 2022 17:03

nbbeeken unassigned syz99 Jan 18, 2022

baileympearson reviewed Jan 19, 2022

View reviewed changes

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

fix: collection name and cleanup

7a8db7b

nbbeeken requested a review from baileympearson January 19, 2022 17:59

baileympearson previously approved these changes Jan 19, 2022

View reviewed changes

dariakp requested changes Jan 19, 2022

View reviewed changes

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

test: admin user sees all dbs

64cc269

nbbeeken dismissed baileympearson’s stale review via 64cc269 January 19, 2022 20:02

nbbeeken requested a review from dariakp January 19, 2022 20:03

dariakp requested changes Jan 20, 2022

View reviewed changes

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

test/integration/enumerate_databases.test.ts Outdated Show resolved Hide resolved

fix: adjust test organization

a95a209

nbbeeken requested a review from dariakp January 21, 2022 16:23

baileympearson previously approved these changes Jan 21, 2022

View reviewed changes

dariakp requested changes Jan 21, 2022

View reviewed changes

test/integration/enumerate_databases/enumerate_databases.prose.test.ts Show resolved Hide resolved

test: ensure created db is included in listDatabases

9b6bf6d

nbbeeken dismissed baileympearson’s stale review via 9b6bf6d January 21, 2022 22:21

nbbeeken requested a review from dariakp January 21, 2022 22:24

test: all the databases in mongod

b4970fd

baileympearson reviewed Jan 24, 2022

View reviewed changes

baileympearson previously approved these changes Jan 24, 2022

View reviewed changes

dariakp requested changes Jan 24, 2022

View reviewed changes

test/integration/enumerate_databases/enumerate_databases.prose.test.ts Show resolved Hide resolved

test: check length of entire db list

5554fec

nbbeeken dismissed baileympearson’s stale review via 5554fec January 24, 2022 19:11

dariakp approved these changes Jan 24, 2022

View reviewed changes

baileympearson merged commit e61a741 into main Jan 24, 2022

baileympearson deleted the NODE-2556/support-authorizedDatabses-flag branch January 24, 2022 19:41


		await client.db(DB_NAME).createCollection(DB_NAME);

		ENTIRE_DB_LIST = (await client.db('admin').command({ listDatabases: 1 })).databases.map(

test(NODE-2556): add integration testing for listDatabases' authorizedDatabases flag #3101

test(NODE-2556): add integration testing for listDatabases' authorizedDatabases flag #3101

Uh oh!

Conversation

syz99 commented Jan 11, 2022

Description

What is changing?

Is there new documentation needed for these changes?

Double check the following

Uh oh!

nbbeeken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nbbeeken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dariakp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

syz99 commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

baileympearson Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

nbbeeken Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

baileympearson commented Jan 24, 2022

Uh oh!

dariakp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dariakp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

syz99 commented Jan 18, 2022 •

edited

Loading