Skip to content

chore: fix test importing non typescript files #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Only import files that end in .ts

What is the motivation for this change?

.DS_Store files make this test fail, so we should filter for .ts

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp merged commit 9613835 into main Dec 14, 2021
@dariakp dariakp deleted the chore/fix-imports-test branch December 14, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants